Skip to content

Remove stack parser support for Opera pre v15 #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 12, 2022
Merged

Remove stack parser support for Opera pre v15 #4923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
97e6ff3
[v7] feat: Remove references to @sentry/apm (#4845)
AbhiPrasad Apr 7, 2022
57d37c2
[v7] feat(core): Delete API class (#4848)
AbhiPrasad Apr 7, 2022
424df27
[v7] feat: Delete deprecated `startSpan` and `child` methods (#4849)
AbhiPrasad Apr 7, 2022
5a7f145
feat(core): Remove whitelistUrls/blacklistUrls (#4850)
AbhiPrasad Apr 7, 2022
f855260
feat(gatsby): Remove Sentry from window (#4857)
AbhiPrasad Apr 7, 2022
f1e9da2
feat(hub): Remove getActiveDomain (#4858)
AbhiPrasad Apr 7, 2022
55b0570
feat(types): Remove deprecated user dsn field (#4864)
AbhiPrasad Apr 7, 2022
2fc13c6
feat(hub): Remove setTransaction scope method (#4865)
AbhiPrasad Apr 7, 2022
20c7773
[v7] feat: Drop support for Node 6 (#4851)
AbhiPrasad Apr 7, 2022
244eb0e
[v7] feat(tracing): Rename registerRequestInstrumentation -> instrume…
AbhiPrasad Apr 7, 2022
285ca26
fix(test): Increase MongoMemoryServer creation timeout (#4881)
Lms24 Apr 7, 2022
fb1b74f
[v7] feat(node): Remove deprecated `frameContextLines` (#4884)
timfish Apr 7, 2022
81b10fb
[v7] feat(browser): Remove top level eventbuilder exports (#4887)
timfish Apr 7, 2022
a0792da
Merge branch '7.x' of https://github.com/getsentry/sentry-javascript …
timfish Apr 8, 2022
edc9929
Merge remote-tracking branch 'upstream/7.x' into 7.x
timfish Apr 12, 2022
a7e70ad
Remove Opera < v15 support from default stack parsers
timfish Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/browser/src/stack-parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,7 @@ const opera11: StackLineParserFn = line => {

export const opera11StackParser: StackLineParser = [OPERA11_PRIORITY, opera11];

export const defaultStackParsers = [
chromeStackParser,
geckoStackParser,
opera10StackParser,
opera11StackParser,
winjsStackParser,
];
export const defaultStackParsers = [chromeStackParser, geckoStackParser, winjsStackParser];

/**
* Safari web extensions, starting version unknown, can produce "frames-only" stacktraces.
Expand Down
13 changes: 7 additions & 6 deletions packages/browser/test/unit/tracekit/opera.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { createStackParser } from '@sentry/utils';

import { exceptionFromError } from '../../../src/eventbuilder';
import { defaultStackParsers } from '../../../src/stack-parsers';
import { defaultStackParsers, opera10StackParser, opera11StackParser } from '../../../src/stack-parsers';

const parser = createStackParser(...defaultStackParsers);
const operaParser = createStackParser(opera10StackParser, opera11StackParser);
const chromiumParser = createStackParser(...defaultStackParsers);

describe('Tracekit - Opera Tests', () => {
it('should parse Opera 10 error', () => {
Expand All @@ -29,7 +30,7 @@ describe('Tracekit - Opera Tests', () => {
'',
};

const ex = exceptionFromError(parser, OPERA_10);
const ex = exceptionFromError(operaParser, OPERA_10);

expect(ex).toEqual({
value: 'Statement on line 42: Type mismatch (usually non-object value supplied where object required)',
Expand Down Expand Up @@ -75,7 +76,7 @@ describe('Tracekit - Opera Tests', () => {
' foo();',
};

const ex = exceptionFromError(parser, OPERA_11);
const ex = exceptionFromError(operaParser, OPERA_11);

expect(ex).toEqual({
value: "'this.undef' is not a function",
Expand Down Expand Up @@ -112,7 +113,7 @@ describe('Tracekit - Opera Tests', () => {
' dumpException3();',
};

const ex = exceptionFromError(parser, OPERA_12);
const ex = exceptionFromError(operaParser, OPERA_12);

expect(ex).toEqual({
value: "Cannot convert 'x' to object",
Expand Down Expand Up @@ -156,7 +157,7 @@ describe('Tracekit - Opera Tests', () => {
' at bar (http://path/to/file.js:108:168)',
};

const ex = exceptionFromError(parser, OPERA_25);
const ex = exceptionFromError(chromiumParser, OPERA_25);

expect(ex).toEqual({
value: "Cannot read property 'undef' of null",
Expand Down