Skip to content

fix(build): Add missing debug logger plugin in debug.min bundle variant config #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lobsterkatie
Copy link
Member

This restores the plugin which includes debug logging in the configuration for our .debug.min bundles. (It was accidentally dropped in #5142.)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.35 KB (-3.93% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.04 KB (-7.09% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.2 KB (-3.52% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.65 KB (-7.45% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.92 KB (-14.29% 🔽)
@sentry/browser - Webpack (minified) 63.11 KB (-22.77% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.94 KB (-14.33% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.73 KB (-9% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.37 KB (-2.71% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.91 KB (-2.36% 🔽)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow regression test this so it doesn’t accidently happen again in the future?

@lobsterkatie
Copy link
Member Author

lobsterkatie commented Jun 2, 2022

Can we somehow regression test this so it doesn’t accidently happen again in the future?

I think this falls under the same heading as testing all the code we use to muck with webpack config in the nextjs SDK - we say to do_____, but what does the eventual bundle look like? And yes, it would be great to get that working. I will make an issue to track it. (Update: done. #5195)

@lobsterkatie lobsterkatie merged commit d49dd9a into master Jun 2, 2022
@lobsterkatie lobsterkatie deleted the kmclb-fix-missing-logging-in-min-debug-bundles branch June 2, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants