feat(remix): Enable Remix SDK #5327
Conversation
AbhiPrasad
force-pushed
the
abhi-remix-enable
branch
from
75e416c to
bddcab0
Compare
Co-authored-by: Michaël De Boey <[email protected]> Co-authored-by: Onur Temizkan <[email protected]>
|
@MichaelDeBoey thank you for the review! |
Co-authored-by: Onur Temizkan <[email protected]>
| tracesSampleRate: 1, | ||
| integrations: [ | ||
| new Sentry.BrowserTracing({ | ||
| routingInstrumentation: Sentry.remixRouterInstrumentation( |
There was a problem hiding this comment.
nit: Why don't we set these properties for the user inside of remixRouterInstrumentation instead of asking them to do this?
There was a problem hiding this comment.
Because dependency injection means that we don’t have to deal with importing the functions ourselves, which means we minimize versioning conflicts.
also init is usually only done once, so it’s not like folks have to come back and touch this code again, so just letting them pass in the imports is fine.
we’ve done this for the rest of our routing instrumentation and never gotten negative feedback.
|
This looks good to me for alpha release. In the upcoming weeks, we should take some time to improve the developer experience here a bit. I believe we could make it easier for users to bootstrap. |
|
Well it seems like the ember tests are failing because https://registry.yarnpkg.com/@types/eslint/-/eslint-8.4.4.tgz is not found while https://www.npmjs.com/package/@types/eslint/v/8.4.4 was just published. I guess we wait it out until it works? Or we switch registries for the yarn tests. |
I'd just wait right now but imo we should install packages in CI with npm ci or lol also just stumbled on this discussion by BYK yarnpkg/yarn#4147 (comment) |
|
Ah here's the issue: DefinitelyTyped/DefinitelyTyped#61032 |
|
|
||
| ## Sourcemaps and Releases | ||
|
|
||
| The Remix SDK provides a script that automatically creates a release and uploads sourcemaps. To generate sourcemaps with Remix, you need to call `remix build` with `--sourcemap` option. |
There was a problem hiding this comment.
| The Remix SDK provides a script that automatically creates a release and uploads sourcemaps. To generate sourcemaps with Remix, you need to call `remix build` with `--sourcemap` option. | |
| The Remix SDK provides a script that automatically creates a release and uploads sourcemaps. To generate sourcemaps with Remix, you need to call `remix build` with the `--sourcemap` option. |
Ref #4894
Enables the publishing of the Sentry Remix SDK. We also rename
upload-sourcemaps->sentry-upload-sourcemaps, and add a small README for instructions.Reverts #5274