Skip to content

ref(tracing): Include transaction in DSC if transaction source is not an unparameterized URL #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2022
Merged

ref(tracing): Include transaction in DSC if transaction source is not an unparameterized URL #5392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2891cbf
ref(tracing): Include transaction in DSC if transaction source is not…
Lms24 Jul 8, 2022
7ffa9dc
generalize createTransactionOnScope test helper function
Lms24 Jul 8, 2022
715bc1d
split up tests
Lms24 Jul 8, 2022
7cf3048
nuke unknown
Lms24 Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tracing/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
const { segment: user_segment } = (scope && scope.getUser()) || {};

const source = this.metadata.source;
const transaction = source && source !== 'url' && source !== 'unknown' ? this.name : undefined;
const transaction = source && source !== 'url' ? this.name : undefined;

return createBaggage(
dropUndefinedKeys({
Expand Down
1 change: 0 additions & 1 deletion packages/tracing/test/span.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,6 @@ describe('Span', () => {
test.each([
['is not included if transaction source is not set', undefined],
['is not included if transaction source is url', 'url'],
['is not included if transaction source is unknown', 'unknown'],
])('%s', (_: string, source) => {
const transaction = new Transaction(
{
Expand Down
2 changes: 0 additions & 2 deletions packages/types/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ export type TransactionSource =
| 'route'
/** Name of the view handling the request */
| 'view'
/** This is the default value set by Relay for legacy SDKs. */
| 'unknown'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.youtube.com/watch?v=-3181HLCwio

/** Named after a software component, such as a function or class name. */
| 'component'
/** Name of a background task (e.g. a Celery task) */
Expand Down