ref(tracing): Use previous source when logging name changes #5733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
AbhiPrasad
force-pushed
the
abhi-prev-source-transaction-name-change
branch
from
9d5df3b to
9a0ab65
Compare
size-limit report 📦
|
lforst
approved these changes
Sep 14, 2022
packages/tracing/src/transaction.ts
Outdated
| @@ -80,7 +80,8 @@ export class Transaction extends SpanClass implements TransactionInterface { | |||
| // parameterized by virtue of having no parameters in its path | |||
| if (name !== this.name || source !== this.metadata.source) { | |||
| this.metadata.changes.push({ | |||
| source, | |||
| // log previous source | |||
| source: this.metadata.source || source, | |||
There was a problem hiding this comment.
Idk about this fallback 🤔 I know this is probably just to make TS happy since the source in metadata might be undefined but in reality, it always has a source. Should we maybe add a comment explaining this?
Or shouldn't the fallback be "custom"?
There was a problem hiding this comment.
you're right - I changed it so that the transaction always defaults to custom, unless explicitly set in metadata.
AbhiPrasad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5679
As per spec change in getsentry/relay#1466, use previous source instead of current one when tracking name changes.