Skip to content

ref(replay): TS fixes for replay #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2022
Merged

ref(replay): TS fixes for replay #6286

merged 2 commits into from
Nov 24, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 24, 2022

There have been some warnings from TS in replay, that should be fixed now.

Also note that since we merged it in, the actual version of the sentry packages increased, so we need to bump this as well for replay.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Nov 24, 2022
@mydea mydea requested review from Lms24 and a team November 24, 2022 12:48
@mydea mydea self-assigned this Nov 24, 2022
@mydea mydea requested review from AbhiPrasad and removed request for a team November 24, 2022 12:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.02% 🔺)
@sentry/replay index.js 83.67 KB (added)
@sentry/replay - Webpack (gzipped + minified) 83.69 KB (added)
@sentry/replay - Webpack (minified) 272.17 KB (added)

@mydea mydea force-pushed the fn/replay-ts-fixes branch from a246812 to d9eba66 Compare November 24, 2022 13:38
@mydea mydea force-pushed the fn/replay-ts-fixes branch from d9eba66 to 3667585 Compare November 24, 2022 14:32
@mydea mydea merged commit 690f74f into master Nov 24, 2022
@mydea mydea deleted the fn/replay-ts-fixes branch November 24, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants