Skip to content

fix(remix): Prevent crashes from failed normalizeRemixRequest calls. #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #6294

Wrap normalizeRemixRequest calls inside try blocks, not to break users' builds / runtimes.

We don't use normalizeRemixRequest for our Express adapter, and also core adapter has higher priority to the Express adapter. So, the original source of #6294 needs more investigation.

But this patch should unblock users until then.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.03% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.02% 🔺)
@sentry/replay index.js 83.67 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 83.69 KB (+0.02% 🔺)
@sentry/replay - Webpack (minified) 272.17 KB (+0.03% 🔺)

@AbhiPrasad AbhiPrasad merged commit a00dceb into master Nov 24, 2022
@AbhiPrasad AbhiPrasad deleted the onur/prevent-crashes-from-normalize-remix-request branch November 24, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: headers[Symbol.for(...)] is not a function in Remix SDK
2 participants