Skip to content

fix(replay): Temporarily build Replay after other packages #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2022
Merged

fix(replay): Temporarily build Replay after other packages #6307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b070710
fix(replay): Temporarily build Replay after other packages
Lms24 Nov 25, 2022
5428375
fix `build` command
Lms24 Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/replay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"scripts": {
"bootstrap": "yarn && cd demo && yarn #TODO: change after migration",
"build": "yarn build:rollup",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, will this work? As build calls build:rollup? 😅 I guess either change build to call build:extra, or remove it? (not sure)

Copy link
Member Author

@Lms24 Lms24 Nov 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I think for CI we'd be fine because build isn't called from the CI (the top-level yarn build executes build:rollup in every package). But I changed it anyway for consistency

"build:rollup": "NODE_ENV=production yarn build:all",
"build:extras": "NODE_ENV=production yarn build:all",
"build:dev": "NODE_ENV=development yarn build:all",
"build:all": "run-s clean build:worker build:core",
"build:core": "yarn build:actualRollup --config config/rollup.config.core.ts",
Expand Down