Skip to content

ci(replay): Ensure replay size limit excludes internal dependencies #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2022
Merged

ci(replay): Ensure replay size limit excludes internal dependencies #6329

merged 1 commit into from
Nov 29, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 29, 2022

This gives us a more "correct" representation of the actual size increase to expect when using replay vs. not using it.

Note that we do want to keep rrweb in there.

@mydea
ci(replay): Ensure replay size limit excludes internal dependencies
2e5e2bc 
Note that we _do_ want to keep `rrweb` in there.
This gives us a more "correct" representation of the actual size increase to expect when using replay vs. not using it.
@mydea mydea added Dev: CI Package: replay Issues related to the Sentry Replay SDK labels Nov 29, 2022
@mydea mydea requested a review from Lms24 November 29, 2022 12:35
@mydea mydea self-assigned this Nov 29, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.54 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.94 KB (0%)
@sentry/browser - Webpack (minified) 65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.83 KB (+0.01% 🔺)
@sentry/replay index.js 63.37 KB (-24.3% 🔽)
@sentry/replay - Webpack (gzipped + minified) 63.37 KB (-24.31% 🔽)
@sentry/replay - Webpack (minified) 204.8 KB (-24.9% 🔽)

@mydea mydea merged commit 1a9d0fc into master Nov 29, 2022
@mydea mydea deleted the fn/replay-size-limit branch November 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Dev: CI Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24