ref(replay): Enable @typescript-eslint/no-floating-promises rule
#6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
size-limit report 📦
|
Lms24
approved these changes
Nov 30, 2022
packages/replay/src/index.ts
Outdated
| @@ -755,7 +755,7 @@ export class Replay implements Integration { | |||
| } | |||
|
|
|||
| if (result.category === 'ui.click') { | |||
| this.triggerUserActivity(); | |||
| void this.triggerUserActivity(); | |||
There was a problem hiding this comment.
l: I'm wondering why this method is async in the first place. Probably missing something but afaict it's never used in an async context.
There was a problem hiding this comment.
good point, I'll just make this un-async!
mydea
force-pushed
the
fn/replay-no-floating-promises
branch
from
fc7b412 to
a906553
Compare
mydea
changed the title
'@typescript-eslint/no-floating-promises' rule@typescript-eslint/no-floating-promises rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was rather straightforward, basically adding
voidbefore floating promises.