-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(replay): Enable no-console
rule
#6347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (usingDeprecatedCaptureOnlyOnError) { | ||
// eslint-disable-next-line no-console | ||
console.warn( | ||
'[@sentry/replay]: The `captureOnlyOnError` option is deprecated! Please configure `errorSampleRate` instead.', | ||
); | ||
} | ||
|
||
if (usingDeprecatedReplaysSamplingRate) { | ||
// eslint-disable-next-line no-console | ||
console.warn( | ||
'[@sentry/replay]: The `replaysSamplingRate` option is deprecated! Please configure `sessionSampleRate` instead.', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is good for now but WDYT, should we think about removing these deprecated options? We're still in alpha and soon bumping to 7.x so it might be wort a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would remove them in a separate PR. I think it makes sense to put this into the 0.x --> 7.x changelog, as people will be most likely to actually read that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, separate PR sounds good to me. Let's just make sure to keep the Replay team informed about it.
size-limit report 📦
|
This enabled
no-console
eslint rule.I left two cases of actual
console.warn
in, where it is basically a deprecation for old settings (which we can probably eventually delete).