feat(replay): Allow to define sample rates on SDK level #6387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/replay-sample-rate
branch
from
da73203 to
3cff119
Compare
Lms24
approved these changes
Dec 2, 2022
mydea
force-pushed
the
fn/replay-sample-rate
branch
4 times, most recently
from
187d663 to
cef5fca
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/replay-sample-rate
branch
from
0c210c5 to
4e8fd1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined in #6351, we want to introduce new top-level options in the browser SDK for replay configuration.
The deprecation of old options will follow in a separate PR.
Note that while working on this, I noticed a potential issue for test flakiness. Namely, that because
setupOnceof the integration is only called once (the first time), and in there we callreplay.start(), the very first test can start out with a started replay, while all following ones wont. I have streamlined this by ensuring we call.stop()in tests after initialising replay. (which does not affect any test as of now, but in other PRs I experiences some flakiness sometimes)