Skip to content

fix(nextjs): Use basePath for assetPrefix if needed #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

lobsterkatie
Copy link
Member

This fixes a bug in #6388, wherein basePath was ignored when determining assetPath. Nextjs copies the former over to the latter if the former is provided and the latter is not. In my original implementation of #6388, the SDK read the values after that had happened, so it was sufficient to look at asssetPath. When I moved the reading of the values earlier, I didn't account for the fact that basePath wouldn't have yet been copied over into assetPath, meaning we have to do it ourselves.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.01 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.74 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.23 KB (0%)

@lforst lforst merged commit 707bbab into master Dec 6, 2022
@lforst lforst deleted the kmclb-nextjs-use-bathPath-for-assetPrefix branch December 6, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants