fix(nextjs): Use basePath
for assetPrefix
if needed
#6424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in #6388, wherein
basePath
was ignored when determiningassetPath
. Nextjs copies the former over to the latter if the former is provided and the latter is not. In my original implementation of #6388, the SDK read the values after that had happened, so it was sufficient to look atasssetPath
. When I moved the reading of the values earlier, I didn't account for the fact thatbasePath
wouldn't have yet been copied over intoassetPath
, meaning we have to do it ourselves.