-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build: Update Lerna to v6 and use Nx caching for builds #6555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a383511
build: Update to lerna 6 & use nx cache for `build`
mydea 57613ab
ref: Ensure we always build when skipping cache
mydea 3d41594
ref: Rename `build:pack` to `build:transpile`
mydea ca6fe0a
fix typo
mydea 3c9a876
PR fixes
mydea 5338268
PR fixes
mydea 22a1277
fix
mydea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,6 +120,11 @@ jobs: | |
| changed_browser: ${{ steps.changed.outputs.browser }} | ||
| changed_browser_integration: ${{ steps.changed.outputs.browser_integration }} | ||
| changed_any_code: ${{ steps.changed.outputs.any_code }} | ||
| # Note: These next three have to be checked as strings ('true'/'false')! | ||
| is_master: ${{ github.ref == 'refs/heads/master' }} | ||
| is_release: ${{ startsWith(github.ref, 'refs/heads/release/') }} | ||
| force_skip_cache: | ||
| ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ci-skip-cache') }} | ||
|
|
||
| job_install_deps: | ||
| name: Install Dependencies | ||
|
|
@@ -139,14 +144,19 @@ jobs: | |
| - name: Compute dependency cache key | ||
| id: compute_lockfile_hash | ||
| run: echo "hash=${{ hashFiles('yarn.lock') }}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| # When the `ci-skip-cache` label is added to a PR, we always want to skip dependency cache | ||
| - name: Check dependency cache | ||
| uses: actions/cache@v3 | ||
| id: cache_dependencies | ||
| if: needs.job_get_metadata.outputs.force_skip_cache == 'false' | ||
| with: | ||
| path: ${{ env.CACHED_DEPENDENCY_PATHS }} | ||
| key: ${{ steps.compute_lockfile_hash.outputs.hash }} | ||
|
|
||
| - name: Install dependencies | ||
| if: steps.cache_dependencies.outputs.cache-hit == '' | ||
| if: | ||
| steps.cache_dependencies.outputs.cache-hit == '' || needs.job_get_metadata.outputs.force_skip_cache == 'true' | ||
| run: yarn install --ignore-engines --frozen-lockfile | ||
| outputs: | ||
| dependency_cache_key: ${{ steps.compute_lockfile_hash.outputs.hash }} | ||
|
|
@@ -168,12 +178,35 @@ jobs: | |
| with: | ||
| path: ${{ env.CACHED_DEPENDENCY_PATHS }} | ||
| key: ${{ needs.job_install_deps.outputs.dependency_cache_key }} | ||
|
|
||
| - name: Check build cache | ||
| uses: actions/cache@v3 | ||
| id: cache_built_packages | ||
| if: needs.job_get_metadata.outputs.force_skip_cache == 'false' | ||
| with: | ||
| path: ${{ env.CACHED_BUILD_PATHS }} | ||
| key: ${{ env.BUILD_CACHE_KEY }} | ||
|
|
||
| - name: NX cache | ||
| uses: actions/cache@v3 | ||
| # Disable cache when: | ||
| # - on master | ||
| # - on release branches | ||
| # - when PR has `ci-skip-cache` label | ||
| if: | | ||
| needs.job_get_metadata.outputs.is_master == 'false' && | ||
| needs.job_get_metadata.outputs.is_release == 'false' && | ||
| needs.job_get_metadata.outputs.force_skip_cache == 'false' | ||
| with: | ||
| path: node_modules/.cache/nx | ||
| key: nx-${{ runner.os }}-${{ github.ref }}-${{ env.HEAD_COMMIT }} | ||
| # GH will use the first restore-key it finds that matches | ||
| # So it will start by looking for one from the same branch, else take the newest one it can find elsewhere | ||
| restore-keys: | | ||
| nx-${{ runner.os }}-${{ github.ref }}-${{ env.HEAD_COMMIT }} | ||
| nx-${{ runner.os }}-${{ github.ref }} | ||
| nx-${{ runner.os }} | ||
|
|
||
| - name: Build packages | ||
| # Under normal circumstances, using the git SHA as a cache key, there shouldn't ever be a cache hit on the built | ||
| # packages, and so `yarn build` should always run. This `if` check is therefore only there for testing CI issues | ||
|
|
@@ -232,7 +265,7 @@ jobs: | |
| timeout-minutes: 15 | ||
| runs-on: ubuntu-20.04 | ||
| # Size Check will error out outside of the context of a PR | ||
| if: github.event_name == 'pull_request' || github.ref == 'refs/heads/master' | ||
| if: github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_master == 'true' | ||
| steps: | ||
| - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -258,7 +291,7 @@ jobs: | |
| - name: Check bundle sizes | ||
| uses: getsentry/size-limit-action@v5 | ||
| # Don't run size check on release branches - at that point, we're already committed | ||
| if: ${{ !startsWith(github.ref, 'refs/heads/release/') }} | ||
| if: needs.job_get_metadata.outputs.is_release == 'false' | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| skip_step: build | ||
|
|
@@ -320,7 +353,7 @@ jobs: | |
| needs: [job_get_metadata, job_build] | ||
| runs-on: ubuntu-20.04 | ||
| # Build artifacts are only needed for releasing workflow. | ||
| if: startsWith(github.ref, 'refs/heads/release/') | ||
| if: needs.job_get_metadata.outputs.is_release == 'true' | ||
| steps: | ||
| - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) | ||
| uses: actions/checkout@v3 | ||
|
|
@@ -339,7 +372,7 @@ jobs: | |
| path: ${{ env.CACHED_BUILD_PATHS }} | ||
| key: ${{ env.BUILD_CACHE_KEY }} | ||
| - name: Pack | ||
| run: yarn build:npm | ||
| run: yarn build:tarball | ||
| - name: Archive artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "lerna": "3.4.0", | ||
| "$schema": "node_modules/lerna/schemas/lerna-schema.json", | ||
| "version": "7.30.0", | ||
| "packages": "packages/*", | ||
| "packages": ["packages/*"], | ||
| "npmClient": "yarn", | ||
| "useWorkspaces": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| { | ||
| "tasksRunnerOptions": { | ||
| "default": { | ||
| "runner": "nx/tasks-runners/default", | ||
| "options": { | ||
| "cacheableOperations": [ | ||
| "build:bundle", | ||
| "build:transpile", | ||
| "build:tarball", | ||
| "build:types" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "targetDefaults": { | ||
| "build:bundle": { | ||
| "dependsOn": [ | ||
| "^build:transpile", | ||
| "build:transpile", | ||
| "^build:types", | ||
| "build:types" | ||
| ], | ||
| "outputs": [ | ||
| "{projectRoot}/build/bundles" | ||
| ] | ||
| }, | ||
| "build:tarball": { | ||
| "dependsOn": [ | ||
| "^build:transpile", | ||
| "build:transpile", | ||
| "^build:types", | ||
| "build:types" | ||
| ], | ||
| "outputs": [] | ||
| }, | ||
| "build:transpile": { | ||
| "dependsOn": [ | ||
| "^build:transpile:uncached", | ||
| "^build:transpile", | ||
| "build:transpile:uncached" | ||
| ], | ||
| "outputs": [ | ||
| "{projectRoot}/build/npm", | ||
| "{projectRoot}/build/esm", | ||
| "{projectRoot}/build/cjs" | ||
| ] | ||
| }, | ||
| "build:types": { | ||
| "dependsOn": [ | ||
| "^build:types" | ||
| ], | ||
| "outputs": [ | ||
| "{projectRoot}/build/types", | ||
| "{projectRoot}/build/npm/types" | ||
| ] | ||
| } | ||
| }, | ||
| "targets": { | ||
| "@sentry/serverless": { | ||
| "build:bundle": { | ||
| "dependsOn": [], | ||
| "outputs": [ | ||
| "{projectRoot}/build/aws" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: should this also depend on
^build:types?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, I guess! I'll add it.