Skip to content

fix(replay): Cater for event processor returning null #6576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

fix(replay): Cater for event processor returning null #6576

merged 1 commit into from
Dec 21, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 18, 2022

This PR fixes an issue where an error is thrown if an event processor returns null.

@timfish timfish force-pushed the fix/replay-event-processor-null branch from 17b5cb6 to d1dde7e Compare December 18, 2022 23:46
@timfish timfish mentioned this pull request Dec 19, 2022
Closed
@timfish timfish added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Dec 19, 2022
Lms24
Lms24 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing this!

@Lms24 Lms24 merged commit 4b19b05 into getsentry:master Dec 21, 2022
@timfish timfish deleted the fix/replay-event-processor-null branch January 5, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @Lms24