Skip to content

build: Add @typescript-eslint/consistent-type-imports rule #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 5, 2023

This ensures we use a type import when we only need type stuff. This rule supports autofix, so running yarn fix will make sure imports are correct.

Thanks @billyvg for the idea!

@mydea mydea requested review from billyvg, lforst and Lms24 January 5, 2023 10:41
@mydea mydea self-assigned this Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.04 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (0%)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This ensures we use a `type` import when we only need type stuff.
@mydea mydea force-pushed the fn/eslint-type-imports branch from b65067c to 3ea7f80 Compare January 11, 2023 14:53
@mydea mydea merged commit 2aa4e94 into master Jan 11, 2023
@mydea mydea deleted the fn/eslint-type-imports branch January 11, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants