fix(replay): Fix ts errors with replay_type
#6681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
commented
Jan 7, 2023
packages/types/src/replay.ts
Outdated
| @@ -10,6 +10,7 @@ export interface ReplayEvent extends Event { | |||
| trace_ids: string[]; | |||
| replay_id: string; | |||
| segment_id: number; | |||
| replay_type: 'session' | 'error'; | |||
There was a problem hiding this comment.
This is of type ReplayRecordingMode, but that type is defined in replays/types and would probably cause circular import issues -- should we move that type into types package?
There was a problem hiding this comment.
Yes, I think that makes sense! I'll move it there and get this PR merged (so we unblock master) 👍
| @@ -922,7 +922,7 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| const transport = client && client.getTransport(); | |||
| const dsn = client?.getDsn(); | |||
|
|
|||
| if (!client || !scope || !transport || !dsn) { | |||
| if (!client || !scope || !transport || !dsn || !this.session || !this.session.sampled) { | |||
There was a problem hiding this comment.
This should never be the case in this method but needed for ts and got rid of optional chaining
size-limit report 📦
|
mydea
force-pushed
the
fix-replay-fix-ts-replay-type
branch
from
d7c84b5 to
6cdcd81
Compare
Lms24
approved these changes
Jan 9, 2023
Fixes type error from #6658 (semantic merge issue).
mydea
force-pushed
the
fix-replay-fix-ts-replay-type
branch
from
017b763 to
e120865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes type error from #6658 (semantic merge issue).