feat(replay): Track pending events in EventBuffer
#6699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
changed the base branch from
master
to
feat-replay-change-addevent-to-be-async
billyvg
changed the title
EventBuffer
size-limit report 📦
|
billyvg
force-pushed
the
feat-replay-eventbuffer-save-pending-events
branch
from
c58b7c0 to
efa539c
Compare
|
Do I understand correctly, this doesn't really do anything right now, and is just needed as a prerequisite for #6698? |
|
@mydea Correct |
billyvg
force-pushed
the
feat-replay-change-addevent-to-be-async
branch
2 times, most recently
from
c400bb0 to
024c4ca
Compare
billyvg
force-pushed
the
feat-replay-eventbuffer-save-pending-events
branch
from
efa539c to
be829e1
Compare
mydea
approved these changes
Jan 11, 2023
billyvg
force-pushed
the
feat-replay-change-addevent-to-be-async
branch
from
2bed985 to
97cb8ea
Compare
Base automatically changed from
feat-replay-change-addevent-to-be-async
to
master
January 11, 2023 18:09
* Track raw pending events in `EventBuffer`. This can be helpful in the case where page is reloaded before the worker has a chance to close the compression stream. * Change `EventBuffer.length` to `EventBuffer.pendingLength` to better reflect what it is. In the case of compression worker, it is async, so recent events added to the buffer are not necessarily present in the workers compression stream.
billyvg
force-pushed
the
feat-replay-eventbuffer-save-pending-events
branch
from
be829e1 to
2756060
Compare
billyvg
added a commit
that referenced
this pull request
Jan 11, 2023
* Track raw pending events in `EventBuffer`. This can be helpful in the case where page is reloaded before the worker has a chance to close the compression stream. * Change `EventBuffer.length` to `EventBuffer.pendingLength` to better reflect what it is. In the case of compression worker, it is async, so recent events added to the buffer are not necessarily present in the workers compression stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventBuffer. This can be helpful in the casewhere page is reloaded before the worker has a chance to close the compression
stream.
EventBuffer.lengthtoEventBuffer.pendingLengthto better reflectwhat it is. In the case of compression worker, it is async, so recent events
added to the buffer are not necessarily present in the workers compression
stream.
Requires #6696, #6695