Skip to content

ref(replay): Remove clearSession from replay API #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

ref(replay): Remove clearSession from replay API #6704

merged 1 commit into from
Jan 11, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 10, 2023

As this was only used for tests, we instead make it a test util.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 10, 2023
@mydea mydea requested review from billyvg and Lms24 January 10, 2023 09:56
@mydea mydea self-assigned this Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.03 KB (-0.05% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (-0.12% 🔽)

@mydea mydea force-pushed the fn/replay-clearSessionTests branch from 545288d to 010db13 Compare January 10, 2023 11:51
@mydea
ref(replay): Remove clearSession from replay API
e36aed0 
As this was only used for tests, we instead make it a test util.
@mydea mydea force-pushed the fn/replay-clearSessionTests branch from 010db13 to e36aed0 Compare January 11, 2023 10:49
@mydea mydea enabled auto-merge (squash) January 11, 2023 10:53
@mydea mydea merged commit 277264e into master Jan 11, 2023
@mydea mydea deleted the fn/replay-clearSessionTests branch January 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @billyvg @Lms24