Skip to content

ref(replay): Mark all methods & properties as public/private #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

ref(replay): Mark all methods & properties as public/private #6734

merged 1 commit into from
Jan 12, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 11, 2023

Enable the @typescript-eslint/explicit-member-accessibility eslint rule & ensure we mark everything as private/public in replay.

This also required renaming all the private stuff with _XXX.

ref: #6323

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 11, 2023
@mydea mydea requested review from billyvg and Lms24 January 11, 2023 13:52
@mydea mydea self-assigned this Jan 11, 2023
@mydea mydea mentioned this pull request Jan 11, 2023
Closed
6 tasks
@mydea mydea force-pushed the fn/replay-public-private branch from d0b28e3 to 49c7d30 Compare January 11, 2023 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.95 KB (-0.43% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.33 KB (-0.01% 🔽)

billyvg
billyvg approved these changes Jan 11, 2023
View reviewed changes
@mydea mydea force-pushed the fn/replay-public-private branch from 49c7d30 to 7e27a75 Compare January 11, 2023 15:30
Lms24
Lms24 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea force-pushed the fn/replay-public-private branch from 7e27a75 to cbbc97e Compare January 12, 2023 09:46
@mydea mydea merged commit f432d09 into master Jan 12, 2023
@mydea mydea deleted the fn/replay-public-private branch January 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @billyvg @Lms24