[Gitflow] MANUALLY merge master into develop #6996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Scope.getLastBreadcrumb` was introduced quite recently for replay and it generally works fine. Just in the few edge cases, where the base SDK version can't be changed or multiple hubs cause conflicts, Replay will crash when the method is not available on the passed scope. This patch lets `handleScope` early-return `null` in case the `getLastBreadcrumb` method does not exist. This will lead to missing breadcrumbs in the replay but at least it will avoid a crash.
… some recording options (#6645) * Deprecate `maskTextSelector`, `maskTextClass`, `blockClass`, `blockSelector`, `ignoreClass` in favor of new API: `mask`, `block`, `ignore` which accepts an array of CSS selectors. * Adds new API for unmasking and unblocking elements: `unmask`, `unblock`. This can be used in conjunction with `maskAllText`, `blockAllMedia` to have privacy by default and selectively unmask elements.
Since we decided to set both replay sample rates to 0 by default, we should log a warning that replay will be disabled if no sample rates were passed to Sentry.init. Since we're still supporting the deprecated sample rates in the integration options, this warning will only be emitted if these rates aren't set either.
…undary` and `showReportDialog` (#6987)
size-limit report 📦
|
Move sample rate from tags into context as that is the more appropriate location for this type of data. This data is more for us to collect to debug rather than having as a top level field on the replay event.
lforst
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to verify if this works.