feat(replay): Stop recording when hitting a rate limit #7018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-replay-stop-on-ratelimit
branch
from
d074416 to
4c2a170
Compare
Lms24
commented
Feb 1, 2023
| @@ -64,120 +64,9 @@ describe('Integration | rate-limiting behaviour', () => { | |||
| replay && replay.stop(); | |||
| }); | |||
|
|
|||
| it.each([ | |||
There was a problem hiding this comment.
IMO we don't need these tests anymore, as they only tested that we pause correctly for different rate limit timeouts we might receive from the Sentry backend. Just ensuring that we don't do anything after a 429 response should be good enough
There was a problem hiding this comment.
Yes, makes sense! 👍 We could even move it to the general sendReplay tests I guess?
There was a problem hiding this comment.
Generally I think it makes sense but given that we have this neat comment under the last test,
// NOTE: If you add a test after the last one, make sure to adjust the test setup
// As this ends with a `stopped()` replay, which may prevent future tests from working
// Sadly, fixing this turned out to be much more annoying than expected, so leaving this warning here for nowand that I ran exactly into this problem, wasting 30minutes trying fix it, I'd vote we leave it as is.
There was a problem hiding this comment.
ahh, right 🙈 damn we should fix those xD
Lms24
changed the title
size-limit report 📦
|
mydea
approved these changes
Feb 1, 2023
|
One comment: I guess this should be |
billyvg
approved these changes
Feb 1, 2023
Lms24
changed the title
mydea
added a commit
that referenced
this pull request
Nov 2, 2023
We changed this [here](#7018), but apparently it is possible to have responses with a 200 status code but rate limit headers. This PR updates our handling to stop either for a non-200 status code, _or_ for a rate limit header. I also streamlined the tests for this a bit, we were testing a bunch of unrelated things, IMHO it's enough to test we stopped/didn't stop. Resolves: getsentry/sentry#49498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed and outlined in #6984, we want to entirely stop recording the replay once we receive a 429 rate limit response. This PR gets rid of all the "pause on rate limit" logic. Because we already stop when we receive other http error responses, we can simply use this logic instead.
Note: feat() over ref() because it's a behaviour change, not because handling rate limits is entirely new (#6710)
closes #6984