Skip to content

fix(replay): Update worker.js to remove console log #7098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 8, 2023

Remember this from my last PR #7082?

Note: Not sure why the worker.js file changed

LOL, now we know. I temporarily added a console.log statement in the worker's compressor, triggering a new worker build. For whatever reason, after removing the log statement, I didn't build the worker again, letting this log statement end up in develop

@Lms24 Lms24 requested a review from mydea February 8, 2023 15:56
@Lms24 Lms24 changed the title fix(replay): Update logger.js to remove console log fix(replay): Update worker.js to remove console log Feb 8, 2023
@Lms24 Lms24 force-pushed the lms-replay-unstale-worker branch from 0b36f7b to dfdc36e Compare February 8, 2023 15:58
@Lms24 Lms24 force-pushed the lms-replay-unstale-worker branch from dfdc36e to 717a4cf Compare February 8, 2023 15:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR 45638e4 88.20 ms 128.36 ms +40.16 ms +45.53 % 160.00 ms +71.80 ms +81.41 %
Previous b539b36 91.57 ms 120.17 ms +28.60 ms +31.23 % 145.54 ms +53.97 ms +58.94 %
CLS This PR 45638e4 0.06 ms 0.06 ms -0.00 ms -0.04 % 0.06 ms +0.00 ms +0.01 %
Previous b539b36 0.06 ms 0.06 ms -0.00 ms -0.38 % 0.06 ms -0.00 ms -0.41 %
CPU This PR 45638e4 20.63 % 22.09 % +1.46 pp +7.08 % 42.57 % +21.94 pp +106.31 %
Previous b539b36 20.10 % 20.34 % +0.24 pp +1.21 % 36.63 % +16.53 pp +82.26 %
JS heap avg This PR 45638e4 1.93 MB 2 MB +68.89 kB +3.56 % 3.03 MB +1.1 MB +56.71 %
Previous b539b36 1.94 MB 2 MB +60.28 kB +3.11 % 3.06 MB +1.12 MB +57.77 %
JS heap max This PR 45638e4 2.3 MB 2.56 MB +261.89 kB +11.37 % 4.57 MB +2.26 MB +98.25 %
Previous b539b36 2.31 MB 2.58 MB +277.13 kB +12.02 % 4.54 MB +2.23 MB +96.89 %
netTx This PR 45638e4 0 B 0 B 0 B n/a 2.61 kB +2.61 kB n/a
Previous b539b36 0 B 0 B 0 B n/a 2.61 kB +2.61 kB n/a
netRx This PR 45638e4 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous b539b36 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR 45638e4 0 0 0 n/a 1 +1 n/a
Previous b539b36 0 0 0 n/a 1 +1 n/a
netTime This PR 45638e4 0.00 ms 0.00 ms 0.00 ms n/a 98.15 ms +98.15 ms n/a
Previous b539b36 0.00 ms 0.00 ms 0.00 ms n/a 114.29 ms +114.29 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b539b36+53.97 ms-0.00 ms+16.53 pp+1.12 MB+2.23 MB+2.61 kB+41 B+1+114.29 ms
6462b00+62.18 ms+0.00 ms+23.70 pp+1.1 MB+2.23 MB+2.57 kB+41 B+1+117.17 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 08 Feb 2023 15:59:08 GMT

@Lms24 Lms24 merged commit 5c937aa into develop Feb 8, 2023
@Lms24 Lms24 deleted the lms-replay-unstale-worker branch February 8, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants