Skip to content

feat(sveltekit): Add server-side handleError wrapper #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

feat(sveltekit): Add server-side handleError wrapper #7411

merged 3 commits into from
Mar 10, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 10, 2023 •
edited
Loading

ref #7403

Adds a wrapper for the server-side handleError hook.

Usage is like the following:

src/hooks.server.js

import { handleErrorWithSentry } from '@sentry/sveltekit';

/** @type {import('@sveltejs/kit').HandleServerError} */
function myCustomHandleError() {
 ...
}

// myCustomHandleError is optional
export const handleError = handleErrorWithSentry(myCustomHandleError);

In #7406 I introduced this functionality on the client side.

@AbhiPrasad AbhiPrasad requested a review from Lms24 March 10, 2023 14:18
@AbhiPrasad AbhiPrasad self-assigned this Mar 10, 2023
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 10, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.24 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.95 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.87 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.87 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.62 KB (+0.12% 🔺)
@sentry/browser - Webpack (minified) 67.39 KB (+0.1% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.65 KB (+0.12% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.54 KB (+0.18% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.51 KB (+0.23% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.76 KB (+0.21% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.17 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.19 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.18 KB (+0.09% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54.35 KB (+0.04% 🔺)

@AbhiPrasad
Copy link
Member Author

In e9d8904 I added two additional changes

  1. Renamed wrapHandleErrorWithSentry to handleErrorWithSentry
  2. Made the passing of a custom handleError implementation optional

Lms24
Lms24 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

packages/sveltekit/test/client/handleError.test.ts Outdated
@@ -5,7 +5,7 @@ import { Scope } from '@sentry/svelte';
// eslint-disable-next-line import/no-unresolved
import type { HandleClientError, NavigationEvent } from '@sveltejs/kit';

import { wrapHandleError } from '../../src/client/handleError';
import { wrapHandleErrorWithSentry } from '../../src/client/handleError';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: this needs to be updated I guess 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! good catch.

@AbhiPrasad AbhiPrasad merged commit ed1347e into develop Mar 10, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-sveltekit-server-handle-error branch March 10, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @Lms24