fix(sveltekit): Remove package.json exports #7481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's figure out how to do the multiplexing in some other way.
AbhiPrasad
force-pushed
the
abhi-sveltekit-remove-exports
branch
from
56f7db8 to
172203e
Compare
Lms24
approved these changes
Mar 16, 2023
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This was initially added in #7406 to make sure that vite could resolve the server/client entries properly, but this ended up breaking esm resolution for the server-side.
Instead of the exports approach, we are going to try to multiplex the same way the next.js sdk does.