fix(gatsby): Use import for gatsby-browser.js instead of require
#7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that due to the `require` usage there, treeshaking is not working as expected. Just replacing this with using esm `import` seems to resolve this. I tried this in sentry-docs and a reproduction app and it seemed good to me.
mydea
force-pushed
the
fn/gatsby-use-import
branch
from
fd1614a to
2a5e2b3
Compare
AbhiPrasad
approved these changes
Apr 19, 2023
|
Seems to work fine in a gatsby v2 app from my testing - so I think lets ship and see what happens! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that due to the
requireusage there, treeshaking is not working as expected. Just replacing this with using esmimportseems to resolve this. I tried this in sentry-docs and a reproduction app and it seemed good to me.Fixes #7853