Skip to content

feat(nextjs): Mark errors caught from NextJS wrappers as unhandled #8893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 29, 2023

This PR is part of a series of PRs adjusting the exception mechanism's handled value.

For more details see #8890

Changed Instrumentation

This PR addresses the mechanisms set in the NextJS package, more concretely in

  • captureUnderscoreException
  • wrapApiHandlerWithSentry
  • callDataFetcherTraced
  • withErrorInstrumentation
  • wrapServerComponentWithSentry

ref #6073

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.28 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser - Webpack (gzipped) 21.86 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.8 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.2 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.19 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.32 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.84 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.1 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.3 KB (0%)
@sentry/react - Webpack (gzipped) 21.89 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.16 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.8 KB (+0.01% 🔺)

@Lms24 Lms24 self-assigned this Aug 29, 2023
@Lms24 Lms24 requested review from lforst and AbhiPrasad August 29, 2023 12:51
@Lms24 Lms24 marked this pull request as ready for review August 29, 2023 12:51
@Lms24 Lms24 changed the title fix(nextjs): Mark errors caught from NextJS wrappers as unhandled feat(nextjs): Mark errors caught from NextJS wrappers as unhandled Aug 29, 2023
@Lms24
Copy link
Member Author

Lms24 commented Aug 29, 2023

Back to draft, we're probably missing a few places here...

@Lms24 Lms24 marked this pull request as draft August 29, 2023 13:21
@Lms24 Lms24 marked this pull request as ready for review August 30, 2023 07:28
@Lms24 Lms24 merged commit b102817 into develop Sep 4, 2023
@Lms24 Lms24 deleted the lms/fix-handled-unhandled-nextjs branch September 4, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants