feat(node): Add Fastify integration

[mydea]

This adds a new Fastify integration to @sentry/node, which does two things:

1. Isolate scope per request
2. Capture errors

Note that it does not support performance monitoring for now, as we're exploring to only add this in the upcoming OTEL-based performance world. But even so, this should already be useful (and can also be used in the node-experimental world).

Usage

const Sentry = require('@sentry/node');
const fastify = require('fastify');

const app = fastify();

Sentry.init({
  integrations: [
    new Sentry.Integrations.Fastify({ fastify: app })
  ],
});

// Add routes etc. to app

ref #4784

[AbhiPrasad]

I really would like us to avoid the pattern of passing in the app instance to the integration. I know we've done this in previous cases, but it leads to the situation where Sentry isn't the first thing you call in your app, which has other consequences.

Could we work around this somehow? Ideally we can fix all cases of this in v8.

[mydea]

I really would like us to avoid the pattern of passing in the app instance to the integration. I know we've done this in previous cases, but it leads to the situation where Sentry isn't the first thing you call in your app, which has other consequences.

Could we work around this somehow? Ideally we can fix all cases of this in v8.

The challenge I am trying to solve is to make this work in current @sentry/node, but also leverage the error handling for @sentry/node-experimental. And monkey patching there is a bit different as we'll need to make sure to not interact with the OTEL patches etc.

IMHO even with this pattern you can solve this by adding the integration later, like:

Sentry.init({
  integrations: []
});

// later your app is setup
getCurrentHub().getClient().addIntegration(new Sentry.Integrations.Fastify({ fastify: app });

Would this be acceptable in your book? Or would you generally want to avoid any instance passing, in any place?

If we want to prioritize that we do not need to pass the instance in at all, I'll have to see how to do this nicely. FWIW, we can also duplicate the plugin for node-experimental (it's not really that complicated, the error capturing code), though it would be nice to use the same code there I guess.

[AbhiPrasad]

you're right that getCurrentHub().getClient().addIntegration does work in this case, maybe we should be talking about that more in the docs.

lgtm for errors, nice work!

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	84.24 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	31.41 KB (0%)
@sentry/browser - Webpack (gzipped)	22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	78.77 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	28.59 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped)	21 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	254.38 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	86.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	62.35 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	31.45 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	84.27 KB (0%)
@sentry/react - Webpack (gzipped)	22.05 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	102.23 KB (0%)
@sentry/nextjs Client - Webpack (gzipped)	50.99 KB (0%)

[aldy505]

Hello! Is there anything blocking this PR?

[mydea]

Hey! Mostly we are exploring a bit if we want to follow this path or try something else. (e.g. can we automatically set this up without having the user add any plugins manually)! We'll keep you updated here.

[anonrig]

require('node:timers/promises').setTimeout exist. We don't need to await new Promise here. Although, it might not work with Node 8.

[csvan]

Very excited for this - my employer uses Fastify extensively and recently started integrating Sentry. Please let me know if I can assist in any way to get this through.