feat(feedback): use custom prepare/send, re-use createEventEnvelope from core #9432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
changed the base branch from
develop
to
feat-feedback-implement-widget-api
billyvg
force-pushed
the
feat-feedback-use-envelopes
branch
from
e274114 to
7543baf
Compare
billyvg
changed the title
billyvg
commented
Nov 1, 2023
Comment on lines
34
to
38
| return client.captureEvent( | ||
| baseEvent, | ||
| { | ||
| event_id: uuid4(), | ||
| }, |
There was a problem hiding this comment.
What are the trade offs for using captureEvent @mydea? We haven't really talked about any hooks that would be needed, but could be a possibility down the road. This would save us from having a lot of custom code, but I don't know how to find out if captureEvent fails so that we can show the user an error.
There was a problem hiding this comment.
I think the core thing is for it to go through event processors etc. Which we have to think about if we want this even 🤔
size-limit report 📦
|
billyvg
force-pushed
the
feat-feedback-implement-widget-api
branch
from
9c4c7cc to
cc43a04
Compare
Base automatically changed from
feat-feedback-implement-widget-api
to
develop
November 6, 2023 22:23
billyvg
force-pushed
the
feat-feedback-use-envelopes
branch
from
7543baf to
1a49823
Compare
mydea
reviewed
Nov 7, 2023
mydea
reviewed
Nov 7, 2023
mydea
reviewed
Nov 7, 2023
billyvg
force-pushed
the
feat-feedback-use-envelopes
branch
from
f88ddde to
380d8fe
Compare
billyvg
commented
Nov 7, 2023
| @@ -4,6 +4,7 @@ export type { OfflineStore, OfflineTransportOptions } from './transports/offline | |||
| export type { ServerRuntimeClientOptions } from './server-runtime-client'; | |||
|
|
|||
| export * from './tracing'; | |||
| export { createEventEnvelope } from './envelope'; | |||
There was a problem hiding this comment.
Are we good to export this @mydea?
This also means we'll have to wait for an SDK release before we can release a new version of the SDK
JoshFerge
reviewed
Nov 8, 2023
There was a problem hiding this comment.
schema etc. looks good to me. only other thought is i'm wondering if the feedback context should set some kind of signifier that it's the "widget". maybe referrer:widget or feedback_source:widget?
thinking we can do the same for crash report, e.g. feedback_source:crash_report
mydea
approved these changes
Nov 8, 2023
billyvg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of our temporary ingest endpoint, and use our normal ingestion instead.