Skip to content

ref(feedback): Do not import window from browser pkg to avoid circular import #9604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2023
Merged

ref(feedback): Do not import window from browser pkg to avoid circular import #9604

merged 4 commits into from
Nov 20, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 20, 2023 •
edited
Loading

We will be exporting the Feedback package from the @sentry/browser package, so to avoid circular imports when we do, we should remove imports from @sentry/browser

(this is what we did in Replay)

@billyvg billyvg changed the title do not import window from browser pkg (circular import) ref(feedback): Do not import window from browser pkg to avoid circular import Nov 20, 2023
@billyvg billyvg mentioned this pull request Nov 20, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.61 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.72 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser - Webpack (gzipped) 21.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.03 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.71 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.85 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.92 KB (+0.13% 🔺)
@sentry/react - Webpack (gzipped) 21.36 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.66 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.15 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.12 KB (-0.25% 🔽)

@billyvg billyvg marked this pull request as ready for review November 20, 2023 21:54
@billyvg billyvg merged commit b46a1bb into develop Nov 20, 2023
@billyvg billyvg deleted the ref-feedback-remove-browser-imports branch November 20, 2023 22:22
billyvg added a commit that referenced this pull request Dec 1, 2023
@billyvg
feat(feedback): Include Feedback package in browser SDK (#9586)
f8cebde 
Add feedback to craft publish list, and export `Feedback` integration
from browser SDK

Depends on

- [x] #9588 
- [x] #9604

Relates to: getsentry/team-replay#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @AbhiPrasad