fix(replay): Capture JSON XHR response bodies #9623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
Nov 21, 2023
|
|
||
| __DEBUG_BUILD__ && logger.info('[Replay] Skipping network body because of body type', body); | ||
|
|
||
| return [undefined]; |
There was a problem hiding this comment.
We should have a NetworkMetaWarning for this case as well
| body: XMLHttpRequest['response'], | ||
| responseType: XMLHttpRequest['responseType'], | ||
| ): [string | undefined, NetworkMetaWarning?] { | ||
| logger.log(body, responseType, typeof body); |
mydea
force-pushed
the
fn/xhr-response-body
branch
from
9476ae3 to
87fe76a
Compare
|
OK, so I updated this to:
|
mydea
force-pushed
the
fn/xhr-response-body
branch
from
4810a9b to
82f8154
Compare
billyvg
approved these changes
Dec 4, 2023
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stupid, now that I figured it out. Basically, if you set
xhr.responseType = 'json', it will forcexhr.responseto be a POJO - which we can't parse right now.We now handle this case specifically.
This also adds a new
UNPARSEABLE_BODY_TYPEmeta warning if we are not getting a body because it is not matching any of the known/parsed types.Closes #9339