Skip to content

chore(astro): Allow Astro 4.0 in peer dependencies #9683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 28, 2023

Astro 4.0.0 beta is out so let's adjust our peer deps!
I opted for an open max version for now. There's a risk of this being problematic with future major versions but I'd argue we'd get support requests either way. The important part IMO is the lower bound.

@Lms24 Lms24 requested review from HazAT and lforst November 28, 2023 09:38
@Lms24 Lms24 merged commit f2e57ad into develop Nov 28, 2023
@Lms24 Lms24 deleted the lms/chore-astro-4.0-peer-dep-bump branch November 28, 2023 09:53
@silent1mezzo
Copy link

@Lms24 This doesn't seem to actually fix the problem. Checking on https://semver.npmjs.com/ it doesn't include the 4.0 beta releases.

Screenshot 2023-11-28 at 2 22 32 PM

Trying to install @sentry/[email protected] into a project with astro@beta installed errors out on peer dependency

Screenshot 2023-11-28 at 2 32 12 PM

@Lms24
Copy link
Member Author

Lms24 commented Nov 29, 2023

@silent1mezzo thanks for raising! It seems this is related to beta/preview versions not being included in the >=[Major].x range. If you search for >=2.x, you'll also get 3.x versions. So I assume this is going to be resolved once a stable Astro 4.0 version is published.

I tried playing around with >=4.0.0-beta || >= 3.x but it also only gives me 3.x releases. Which is weird because only >=4.0.0-beta actually returns both 4.0.0 beta versions... Using the semver package, the range seems to be okay though. Maybe a bug in the website...

I'm temporarily gonna add the beta range to see if it solves this but all in all won't spend too much time on this though - the important thing is that we support 4.0 once it's stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants