Skip to content

build: enable biome linter #9692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2023
Merged

build: enable biome linter #9692

merged 2 commits into from
Nov 30, 2023

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Nov 28, 2023

Enables Biome linter and moves several rules to Biome.

Running time yarn lint

Before

yarn lint  221.52s user 19.65s system 783% cpu 30.797 total

After

yarn lint  212.49s user 19.99s system 772% cpu 30.756 total

@anonrig anonrig requested review from a team, lforst and AbhiPrasad and removed request for a team November 28, 2023 20:45
@lforst
Copy link
Contributor

lforst commented Nov 29, 2023

Can you elaborate a bit more what impact this might have? I am worried about:

  • How will this work with LSPs? (I mostly care about VSCode)
  • Are 8s worth the additional dependency in our toolchain?

@anonrig
Copy link
Contributor Author

anonrig commented Nov 29, 2023

Can you elaborate a bit more what impact this might have? I am worried about:

Definitely, @lforst

  • How will this work with LSPs? (I mostly care about VSCode)

We already have enabled Biome plugin on .vscode/extensions.json. Biome LSP is enabled and works correctly.

  • Are 8s worth the additional dependency in our toolchain?

We don't add a new dependency. We already use Biome for formatting. We just enable the functionality of linting of Biome.

@anonrig
Copy link
Contributor Author

anonrig commented Nov 29, 2023

@lforst I updated the VSCode settings. From now on, we don't need to have to ask developers to update VSCode settings for Biome specific actions.

@anonrig anonrig force-pushed the enable-biome-linter branch from 2057b81 to 165ba31 Compare November 29, 2023 18:46
@anonrig anonrig force-pushed the enable-biome-linter branch from 165ba31 to 10f8ab1 Compare November 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants