Skip to content

ref(serverless): Use startSpanManual() instead of startTransaction() #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 22, 2023

Also refactor it to use continueTrace.

Note that this already uses the "new" way of startSpanManual which ignores the finish function.

@mydea mydea requested review from lforst and Lms24 December 22, 2023 09:19
@mydea mydea self-assigned this Dec 22, 2023
@mydea mydea force-pushed the fn/idleTransaction branch from 8bc1613 to a9d120e Compare December 22, 2023 10:01
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this really looks way cleaner!

@mydea mydea force-pushed the fn/idleTransaction branch from 7747255 to 3a5d3f9 Compare December 22, 2023 14:23
@mydea mydea enabled auto-merge (squash) December 22, 2023 14:30
@mydea mydea merged commit eadfd61 into develop Dec 22, 2023
@mydea mydea deleted the fn/idleTransaction branch December 22, 2023 14:36
anonrig pushed a commit that referenced this pull request Jan 3, 2024
…()` (#9970)

Also refactor it to use `continueTrace`.

Note that this already uses the "new" way of `startSpanManual` which
ignores the `finish` function.

---------

Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants