Skip to content

chore: Fix CI failures #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2021
Merged

chore: Fix CI failures #1101

merged 3 commits into from
Apr 29, 2021

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Apr 28, 2021 •
edited
Loading

Fix a bunch of issues with CI that prevent me from releasing

  • django main branch has changed how classbased views work, slightly, view_func is now some sort of closure
  • spark is unmaintained so we can do nothing but remove it from CI for now
  • Flask has a RC-version released so it generally feels safer to allow those weird versions to be used with the SDK

@untitaker untitaker mentioned this pull request Apr 28, 2021
Closed
@untitaker untitaker changed the title fix: Allow enabling Flask integration if version is unparseable chore: Fix CI failures Apr 29, 2021
@untitaker untitaker requested a review from ahmedetefy April 29, 2021 10:02
@ahmedetefy
Copy link
Contributor

Please add a description to the PR

@untitaker untitaker merged commit d7cf16c into master Apr 29, 2021
@untitaker untitaker deleted the fix/flask-dev branch April 29, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedetefy ahmedetefy ahmedetefy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @ahmedetefy