Skip to content

toxgen: Add huggingface_hub #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

toxgen: Add huggingface_hub #4299

merged 4 commits into from
Apr 15, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 15, 2025

Also fixes

Repository Not Found for url: https://huggingface.co/api/models/some-model.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated. For more details, see https://huggingface.co/docs/huggingface_hub/authentication
Invalid username or password.
FAILED tests/integrations/huggingface_hub/test_huggingface_hub.py::test_span_origin - huggingface_hub.errors.RepositoryNotFoundError: 401 Client Error. (Request ID: Root=1-67fe4547-10b0ce8f541a41c37ead3b2a;afe45d5d-3af1-45cd-a39a-c8ef4a5211c3)

which started popping up on huggingface_hub 0.30.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (fbf43bd) to head (6fc6865).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4299      +/-   ##
==========================================
+ Coverage   79.96%   80.31%   +0.34%     
==========================================
  Files         142      142              
  Lines       15919    15919              
  Branches     2722     2722              
==========================================
+ Hits        12730    12785      +55     
+ Misses       2324     2262      -62     
- Partials      865      872       +7     

see 3 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review April 15, 2025 12:40
@sentrivana sentrivana requested a review from a team as a code owner April 15, 2025 12:40
@sentrivana sentrivana enabled auto-merge (squash) April 15, 2025 12:41
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question, looks good otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the hardcoded huggingface_hub items from tox.ini also be getting removed here and/or in the yml template?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like they have not been in tox.ini in the first place...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sus lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I think they were missing for some time 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the rest of the integrations not managed by toxgen to make sure this wasn't the case for other test suites -- we should be good

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@sentrivana sentrivana merged commit 0851458 into master Apr 15, 2025
140 checks passed
@sentrivana sentrivana deleted the iavna/toxgen/huggingface branch April 15, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants