-
Notifications
You must be signed in to change notification settings - Fork 548
toxgen: Add huggingface_hub #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4299 +/- ##
==========================================
+ Coverage 79.96% 80.31% +0.34%
==========================================
Files 142 142
Lines 15919 15919
Branches 2722 2722
==========================================
+ Hits 12730 12785 +55
+ Misses 2324 2262 -62
- Partials 865 872 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small question, looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the hardcoded huggingface_hub
items from tox.ini
also be getting removed here and/or in the yml template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like they have not been in tox.ini in the first place...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sus lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I think they were missing for some time 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the rest of the integrations not managed by toxgen to make sure this wasn't the case for other test suites -- we should be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay
Also fixes
which started popping up on huggingface_hub 0.30.