fix(promise-tracking): Remove Sentry frames from synthetic errors #3423

krystofwoldrich · 2023-11-27T11:35:11Z

📢 Type of change

Bugfix

📜 Description

This PR adds synthetic error to unhandled promise rejection to ensure the top of the stack with Sentry SDK frames is removed. Both for local symbolication and for server symbolication.

💡 Motivation and Context

fixes: Multiple tracking.enable$argument_0.onUnhandled error reported #3185

💚 How did you test it?

sample app, unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2023-11-27T11:53:47Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	438.64 ms	462.80 ms	24.16 ms
Size	17.73 MiB	19.84 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms

App size

Revision	Plain	With Sentry	Diff
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

Revision	Plain	With Sentry	Diff
`f0cf443`	405.47 ms	417.69 ms	12.22 ms

App size

Revision	Plain	With Sentry	Diff
`f0cf443`	17.73 MiB	19.84 MiB	2.11 MiB

github-actions · 2023-11-27T12:16:12Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	350.37 ms	373.80 ms	23.43 ms
Size	7.15 MiB	8.11 MiB	988.22 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`9c48b2c`+dirty	270.82 ms	321.12 ms	50.30 ms
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`9c48b2c`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

Revision	Plain	With Sentry	Diff
`f0cf443`+dirty	374.33 ms	405.40 ms	31.07 ms

App size

Revision	Plain	With Sentry	Diff
`f0cf443`+dirty	7.15 MiB	8.11 MiB	988.22 KiB

…andled-synthetic-stack

github-actions · 2023-11-27T16:09:35Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1232.35 ms	1235.22 ms	2.88 ms
Size	2.36 MiB	2.87 MiB	521.62 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

Revision	Plain	With Sentry	Diff
`f0cf443`+dirty	1266.80 ms	1268.67 ms	1.88 ms

App size

Revision	Plain	With Sentry	Diff
`f0cf443`+dirty	2.36 MiB	2.87 MiB	521.64 KiB

src/js/utils/error.ts

Co-authored-by: LucasZF <[email protected]>

test/error.test.ts

lucas-zimerman

LGTM!

…c-symbolication

…andled-synthetic-stack

github-actions · 2023-11-30T17:59:33Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1212.57 ms	1218.70 ms	6.13 ms
Size	2.92 MiB	3.43 MiB	525.30 KiB

krystofwoldrich added 3 commits November 24, 2023 20:15

update changelog

8f58e1d

fix lint

0b4490d

fix(promise-tracking): Remove Sentry frames from synthetic errors

8079b13

krystofwoldrich added 3 commits November 27, 2023 16:20

More refactor and add tests

9d7c3ba

Merge branch 'kw-fix-local-synthetic-symbolication' into kw-fix-onunh…

b91705e

…andled-synthetic-stack

Add skip frames tests

e2a4735

krystofwoldrich added 2 commits November 27, 2023 18:12

Add test

c33bd32

add isErrorLike and only create synthetic error when needed

66aeba6

krystofwoldrich requested review from lforst, Lms24 and AbhiPrasad November 27, 2023 17:46

krystofwoldrich marked this pull request as ready for review November 27, 2023 17:46

krystofwoldrich requested a review from lucas-zimerman as a code owner November 27, 2023 17:47

lucas-zimerman reviewed Nov 30, 2023

View reviewed changes

src/js/utils/error.ts Outdated Show resolved Hide resolved

Update src/js/utils/error.ts

da6cb09

Co-authored-by: LucasZF <[email protected]>

krystofwoldrich requested review from lucas-zimerman November 30, 2023 13:40

lucas-zimerman reviewed Nov 30, 2023

View reviewed changes

test/error.test.ts Show resolved Hide resolved

fix gh suggestion

f733433

lucas-zimerman approved these changes Nov 30, 2023

View reviewed changes

krystofwoldrich added 3 commits November 30, 2023 15:50

fix prettier

b090287

Merge remote-tracking branch 'origin/main' into kw-fix-local-syntheti…

7ba69b6

…c-symbolication

Merge branch 'kw-fix-local-synthetic-symbolication' into kw-fix-onunh…

daa76e2

…andled-synthetic-stack

Base automatically changed from kw-fix-local-synthetic-symbolication to main December 1, 2023 09:10

Merge branch 'main' into kw-fix-onunhandled-synthetic-stack

717324a

krystofwoldrich enabled auto-merge (squash) December 1, 2023 15:45

krystofwoldrich merged commit df12f45 into main Dec 1, 2023

krystofwoldrich deleted the kw-fix-onunhandled-synthetic-stack branch December 1, 2023 15:47

vytick mentioned this pull request Jan 4, 2024

chore(suite): sentry upgrade trezor/trezor-suite#10490

Merged

krystofwoldrich mentioned this pull request Feb 8, 2024

fix(v8/utils): Stack parser skip frames (not lines of stack string) getsentry/sentry-javascript#10560

Merged

Uh oh!

fix(promise-tracking): Remove Sentry frames from synthetic errors #3423

fix(promise-tracking): Remove Sentry frames from synthetic errors #3423

Uh oh!

Conversation

krystofwoldrich commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

App size

Uh oh!

github-actions bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

App size

Uh oh!

github-actions bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-onunhandled-synthetic-stack

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 30, 2023

iOS (new) Performance metrics 🚀

Uh oh!

Uh oh!

krystofwoldrich commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 27, 2023 •

edited

Loading