feat(replay): Fix truncated JSON request/response bodies #59266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
mydea
changed the title
mydea
force-pushed
the
fn/replay-body-truncated
branch
from
92d6527 to
cd1318b
Compare
billyvg
approved these changes
Nov 6, 2023
| @@ -2,6 +2,7 @@ type JsonObject = Record<string, unknown>; | |||
| type JsonArray = unknown[]; | |||
|
|
|||
| export type NetworkMetaWarning = | |||
There was a problem hiding this comment.
Is this exported from SDK at all?
There was a problem hiding this comment.
not right now! We can think about exporting this in the future. but probably this doesn't really make sense here, because we want to keep this broader - we want to keep all values that this could ever have here I think? as we also need to make sure to keep covering older versions?
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Nov 7, 2023
This is potentially performance intensive, so we should just do this in the UI instead. Part of #9426 This was implemented in Sentry in getsentry/sentry#59266
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes from the SDK here: getsentry/sentry-javascript#9437
If it encounters a request/response body with a
MAYBE_TRUNCATED_JSONwarning, it will try to auto-fix it with the same logic as we did in the SDK.