fix(sdk-crashes): Ignore current stacktrace #75140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75140 +/- ##
==========================================
+ Coverage 78.08% 78.09% +0.01%
==========================================
Files 6757 6757
Lines 301570 301570
Branches 51889 51889
==========================================
+ Hits 235488 235522 +34
+ Misses 59732 59706 -26
+ Partials 6350 6342 -8
|
jjbayer
approved these changes
Jul 29, 2024
roaga
pushed a commit
that referenced
this pull request
Jul 31, 2024
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the wrapper function getCurrentStackTrace instead of getSentryException. getCurrentStackTrace is the wrapper function for getting the current stacktrace, and getSentryException uses that function. This was changed with
getsentry/sentry-dart#2072 and shipped in sentry-dart 8.2.1.