-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(flags): add unleash to provider dropdowns and onboarding #82836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de8fcb3
to
97068a6
Compare
Bundle ReportChanges will increase total bundle size by 37.97kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
michellewzhang
commented
Jan 3, 2025
michellewzhang
commented
Jan 6, 2025
michellewzhang
commented
Jan 7, 2025
michellewzhang
commented
Jan 7, 2025
f6dc40c
to
8d9aff4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82836 +/- ##
===========================================
+ Coverage 46.61% 80.45% +33.84%
===========================================
Files 9475 7302 -2173
Lines 537220 319217 -218003
Branches 21175 20943 -232
===========================================
+ Hits 250407 256834 +6427
+ Misses 286456 61981 -224475
- Partials 357 402 +45 |
aliu39
reviewed
Jan 14, 2025
aliu39
approved these changes
Jan 15, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
branched off of #82387 closes getsentry/team-replay#515 closes getsentry/team-replay#530 ### settings page <img width="995" alt="SCR-20250102-mncr" src="https://github.com/user-attachments/assets/6404d15c-94da-41e1-8c13-5215bf2c5b66" /> <img width="997" alt="SCR-20250102-mnew" src="https://github.com/user-attachments/assets/e15f10df-ba01-48ed-9f29-75db4fc745ef" /> ### onboarding dropdowns <img width="450" alt="SCR-20250102-mnbf" src="https://github.com/user-attachments/assets/b9a733e4-dc98-4217-baca-9d1ed95d8980" /> <img width="435" alt="SCR-20250102-mnag" src="https://github.com/user-attachments/assets/f05a781f-752a-4f4c-a4d3-af217773c6a3" /> ### python onboarding <img width="467" alt="SCR-20250107-jlgk" src="https://github.com/user-attachments/assets/978a31ff-3929-480f-ae24-2d2cc48c17f8" /> ### js onboarding <img width="472" alt="SCR-20250114-jlyw" src="https://github.com/user-attachments/assets/0c43d47d-15fe-4d3e-ae8d-85cf8afe3f12" /> ### also updated generic python onboarding: <img width="477" alt="SCR-20250114-kyvf" src="https://github.com/user-attachments/assets/99aa6824-9e27-4b9f-96cc-3e548c5c8852" /> --------- Co-authored-by: Andrew Liu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branched off of #82387
closes https://github.com/getsentry/team-replay/issues/515
closes https://github.com/getsentry/team-replay/issues/530
settings page
onboarding dropdowns
python onboarding
js onboarding
also updated generic python onboarding: