Skip to content

feat(flags): add unleash to provider dropdowns and onboarding #82836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 15, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Jan 2, 2025

branched off of #82387
closes https://github.com/getsentry/team-replay/issues/515
closes https://github.com/getsentry/team-replay/issues/530

settings page

SCR-20250102-mncr SCR-20250102-mnew

onboarding dropdowns

SCR-20250102-mnbf SCR-20250102-mnag

python onboarding

SCR-20250107-jlgk

js onboarding

SCR-20250114-jlyw

also updated generic python onboarding:

SCR-20250114-kyvf

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 2, 2025
@michellewzhang michellewzhang force-pushed the mz/add-unleash-onboarding branch from de8fcb3 to 97068a6 Compare January 2, 2025 22:01
Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 37.97kB (0.12%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.06MB 37.97kB (0.12%) ⬆️

@michellewzhang michellewzhang force-pushed the mz/add-unleash-onboarding branch from f6dc40c to 8d9aff4 Compare January 7, 2025 20:12
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #82836       +/-   ##
===========================================
+ Coverage   46.61%   80.45%   +33.84%     
===========================================
  Files        9475     7302     -2173     
  Lines      537220   319217   -218003     
  Branches    21175    20943      -232     
===========================================
+ Hits       250407   256834     +6427     
+ Misses     286456    61981   -224475     
- Partials      357      402       +45     

@michellewzhang michellewzhang marked this pull request as ready for review January 14, 2025 18:21
@michellewzhang michellewzhang requested review from a team as code owners January 14, 2025 18:21
@michellewzhang michellewzhang assigned aliu39 and unassigned aliu39 Jan 14, 2025
@michellewzhang michellewzhang merged commit 383c5d7 into master Jan 15, 2025
43 checks passed
@michellewzhang michellewzhang deleted the mz/add-unleash-onboarding branch January 15, 2025 18:07
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
branched off of #82387
closes getsentry/team-replay#515
closes getsentry/team-replay#530

### settings page
<img width="995" alt="SCR-20250102-mncr"
src="https://github.com/user-attachments/assets/6404d15c-94da-41e1-8c13-5215bf2c5b66"
/>
<img width="997" alt="SCR-20250102-mnew"
src="https://github.com/user-attachments/assets/e15f10df-ba01-48ed-9f29-75db4fc745ef"
/>


### onboarding dropdowns
<img width="450" alt="SCR-20250102-mnbf"
src="https://github.com/user-attachments/assets/b9a733e4-dc98-4217-baca-9d1ed95d8980"
/>
<img width="435" alt="SCR-20250102-mnag"
src="https://github.com/user-attachments/assets/f05a781f-752a-4f4c-a4d3-af217773c6a3"
/>

### python onboarding
<img width="467" alt="SCR-20250107-jlgk"
src="https://github.com/user-attachments/assets/978a31ff-3929-480f-ae24-2d2cc48c17f8"
/>


### js onboarding
<img width="472" alt="SCR-20250114-jlyw"
src="https://github.com/user-attachments/assets/0c43d47d-15fe-4d3e-ae8d-85cf8afe3f12"
/>

### also updated generic python onboarding:
<img width="477" alt="SCR-20250114-kyvf"
src="https://github.com/user-attachments/assets/99aa6824-9e27-4b9f-96cc-3e548c5c8852"
/>

---------

Co-authored-by: Andrew Liu <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants