feat(perf-issues): Allow experimental N+1 DB Span detector to pick up MongoDB queries #90756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeandher
changed the title
github-actions
bot
added
the
Scope: Backend
leeandher
commented
May 1, 2025
Comment on lines
-240
to
-245
| def _contains_valid_repeating_query(self, span: Span) -> bool: | ||
| # Make sure we at least have a space, to exclude e.g. MongoDB and | ||
| # Prisma's `rawQuery`. | ||
| query = span.get("description", None) | ||
| return bool(query) and " " in query | ||
|
|
There was a problem hiding this comment.
So I took apart this function and moved it's check to the visit_span method via are_spans_equivalent.
| b_relay_description = b.get("sentry_tags", {}).get("description") | ||
| return a_relay_description == b_relay_description and base_checks | ||
|
|
||
| return base_checks |
There was a problem hiding this comment.
Now, instead of just checking a.hash against b.hash we're also validating that the descriptions match, and aren't empty. These two checks used to only happen after the detector ran through, in _contains_valid_repeating_query and only for the first of the n_spans. Now we're checking every span against the previous explicitly.
For mongodb system spans we also check the relay descriptions which include collection names, for even more confidence.
roggenkemper
approved these changes
May 6, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
… MongoDB queries (#90756) Allows the N+1 detector to operate on MongoDB queries. The example JSON comes from my [prod trace](https://sentry-leander.sentry.io/issues/trace/d1cfb683e06b415b9f89742214dcbc12/?groupId=6566277807&node=ag-1b956e6208c12234&node=txn-a9240785a11d46d393aea0c8bd137f11&pageEnd=2025-04-25T06%3A02%3A16.355&pageStart=2025-04-24T06%3A02%3A16.355&project=4509203466944512&query=&referrer=issue-stream&sort=date&source=issue_details&stream_index=0×tamp=1745517736) that i generated from playing around with empowerplant. Tests work but maybe there's more coverage I should add but I'm not too sure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the N+1 detector to operate on MongoDB queries. The example JSON comes from my prod trace that i generated from playing around with empowerplant. Tests work but maybe there's more coverage I should add but I'm not too sure.