Skip to content

fix(taskworker): Pass simple types to prepare_organization_report task in tests #90768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

enochtangg
Copy link
Member

@enochtangg enochtangg commented May 1, 2025

Testing

export TASK_TYPE_CHECKING=1 && pytest tests/sentry/tasks/test_weekly_reports.py -s -vv
============================================================ test session starts =============================================================
platform darwin -- Python 3.13.1, pytest-8.1.2, pluggy-1.5.0 -- /Users/enochtang/code/sentry/.venv/bin/python3
cachedir: .pytest_cache
metadata: {'Python': '3.13.1', 'Platform': 'macOS-15.3.1-arm64-arm-64bit-Mach-O', 'Packages': {'pytest': '8.1.2', 'pluggy': '1.5.0'}, 'Plugins': {'fail-slow': '0.3.0', 'time-machine': '2.16.0', 'json-report': '1.5.0', 'metadata': '3.1.1', 'xdist': '3.0.2', 'django': '4.9.0', 'pytest_sentry': '0.3.0', 'anyio': '3.7.1', 'rerunfailures': '15.0', 'cov': '4.0.0'}}
django: version: 5.1.7
rootdir: /Users/enochtang/code/sentry
configfile: pyproject.toml
plugins: fail-slow-0.3.0, time-machine-2.16.0, json-report-1.5.0, metadata-3.1.1, xdist-3.0.2, django-4.9.0, pytest_sentry-0.3.0, anyio-3.7.1, rerunfailures-15.0, cov-4.0.0
collected 28 items

tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_deliver_reports_respects_settings Creating test database for alias 'default' ('test_region')...
Creating test database for alias 'control' ('test_control')...
Creating test database for alias 'secondary' ('test_secondary')...
PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_dry_run_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_duplicate_detection PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_invalid_target_user PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_no_target_user PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_empty_report PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_group_status_to_color_obj_correct_length PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_integration PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_invited_member PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_member_disabled PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_advanced PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_filter_resolved PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_filter_to_error_level PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_multiple_users_prevent_resend PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_replays PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_substatus_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_links_customer_domains PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_organization_project_issue_status PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_organization_project_issue_substatus_summaries PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_starts_from_beginning_when_no_redis_key PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_updates_redis_during_processing PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_with_redis_tracking PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_transferred_project PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_user_inactive PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_user_with_team_and_no_projects PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_with_empty_string_user_option PASSEDDestroying test database for alias 'default' ('test_region')...
Destroying test database for alias 'control' ('test_control')...
Destroying test database for alias 'secondary' ('test_secondary')...


============================================================ 28 passed in 22.27s =============================================================
%4|1746129607.823|TERMINATE|rdkafka#producer-1| [thrd:app]: Producer terminating with 1 message (211 bytes) still in queue or transit: use flush() to wait for outstanding message delivery

@enochtangg enochtangg requested a review from a team May 1, 2025 19:58
@enochtangg enochtangg changed the title fix(taskworker): Pass user_id and batch_id str to week prepare_organization_report task in tests fix(taskworker): Pass user_id and batch_id str to prepare_organization_report task in tests May 1, 2025
@enochtangg enochtangg changed the title fix(taskworker): Pass user_id and batch_id str to prepare_organization_report task in tests fix(taskworker): Pass simple types to prepare_organization_report task in tests May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90768       +/-   ##
===========================================
+ Coverage   32.99%   87.80%   +54.80%     
===========================================
  Files        8705    10283     +1578     
  Lines      485199   583519    +98320     
  Branches    22569    22569               
===========================================
+ Hits       160105   512364   +352259     
+ Misses     324664    70725   -253939     
  Partials      430      430               

@enochtangg enochtangg merged commit 8785f43 into master May 2, 2025
57 checks passed
@enochtangg enochtangg deleted the update-test-weekly-report-test branch May 2, 2025 19:42
andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
…k in tests (#90768)

### Testing
```
export TASK_TYPE_CHECKING=1 && pytest tests/sentry/tasks/test_weekly_reports.py -s -vv
============================================================ test session starts =============================================================
platform darwin -- Python 3.13.1, pytest-8.1.2, pluggy-1.5.0 -- /Users/enochtang/code/sentry/.venv/bin/python3
cachedir: .pytest_cache
metadata: {'Python': '3.13.1', 'Platform': 'macOS-15.3.1-arm64-arm-64bit-Mach-O', 'Packages': {'pytest': '8.1.2', 'pluggy': '1.5.0'}, 'Plugins': {'fail-slow': '0.3.0', 'time-machine': '2.16.0', 'json-report': '1.5.0', 'metadata': '3.1.1', 'xdist': '3.0.2', 'django': '4.9.0', 'pytest_sentry': '0.3.0', 'anyio': '3.7.1', 'rerunfailures': '15.0', 'cov': '4.0.0'}}
django: version: 5.1.7
rootdir: /Users/enochtang/code/sentry
configfile: pyproject.toml
plugins: fail-slow-0.3.0, time-machine-2.16.0, json-report-1.5.0, metadata-3.1.1, xdist-3.0.2, django-4.9.0, pytest_sentry-0.3.0, anyio-3.7.1, rerunfailures-15.0, cov-4.0.0
collected 28 items

tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_deliver_reports_respects_settings Creating test database for alias 'default' ('test_region')...
Creating test database for alias 'control' ('test_control')...
Creating test database for alias 'secondary' ('test_secondary')...
PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_dry_run_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_duplicate_detection PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_invalid_target_user PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_no_target_user PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_email_override_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_empty_report PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_group_status_to_color_obj_correct_length PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_integration PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_invited_member PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_member_disabled PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_advanced PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_filter_resolved PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_filter_to_error_level PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_multiple_users_prevent_resend PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_replays PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_builder_substatus_simple PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_message_links_customer_domains PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_organization_project_issue_status PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_organization_project_issue_substatus_summaries PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_starts_from_beginning_when_no_redis_key PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_updates_redis_during_processing PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_schedule_organizations_with_redis_tracking PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_transferred_project PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_user_inactive PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_user_with_team_and_no_projects PASSED
tests/sentry/tasks/test_weekly_reports.py::WeeklyReportsTest::test_with_empty_string_user_option PASSEDDestroying test database for alias 'default' ('test_region')...
Destroying test database for alias 'control' ('test_control')...
Destroying test database for alias 'secondary' ('test_secondary')...


============================================================ 28 passed in 22.27s =============================================================
%4|1746129607.823|TERMINATE|rdkafka#producer-1| [thrd:app]: Producer terminating with 1 message (211 bytes) still in queue or transit: use flush() to wait for outstanding message delivery
```
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants