docs: Add Objective C examples to cocoa onboarding + non UI verification options #92506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
armcknight
reviewed
May 29, 2025
There was a problem hiding this comment.
Based on my reply here, I think the best non-UI (and indeed, probably the best overall) method to verify an install should be to simply capture a message.
If anyone leaves a delayed crash in by accident, it creeps back in due to weird merge situations, etc, that's much higher risk for customers.
There was a problem hiding this comment.
I also think that crashing as pointed out by @armcknight isn't a great idea, but instead of capturing a message I think we should stick to capturing errors. We already do that for most other onboarding docs, and errors are what users use Sentry mostly for.
Comment on lines
240
to
244
| UIButton *button = [UIButton buttonWithType:UIButtonTypeRoundedRect]; | ||
| button.frame = CGRectMake(20, 50, 100, 30); | ||
| [button setTitle:@"Break the world" forState:UIControlStateNormal]; | ||
| [button addTarget:self action:@selector(breakTheWorld:) forControlEvents:UIControlEventTouchUpInside]; | ||
| [view addSubview:button]; |
There was a problem hiding this comment.
m: IMO, we can ditch this part. It's noisy and I doubt many people are going to use it exactly like this.
Suggested change
| UIButton *button = [UIButton buttonWithType:UIButtonTypeRoundedRect]; | |
| button.frame = CGRectMake(20, 50, 100, 30); | |
| [button setTitle:@"Break the world" forState:UIControlStateNormal]; | |
| [button addTarget:self action:@selector(breakTheWorld:) forControlEvents:UIControlEventTouchUpInside]; | |
| [view addSubview:button]; |
Instead, I think we should only show how to capture an error like we do in the docs, which you updated here: getsentry/sentry-docs#13878
I think we should do the same for Swift.
Comment on lines
268
to
274
| DispatchQueue.global().asyncAfter(deadline: .now() + 10) { | ||
| SentrySDK.crash() | ||
| }` | ||
| : ` | ||
| @import Sentry; | ||
|
|
||
| [SentrySDK performSelector:@selector(crash) withObject:nil afterDelay:10];`; |
There was a problem hiding this comment.
h: Why the delay of 10 seconds? I'm pretty sure that could confuse users. Let's simply add a sample how to capture an error and let the user decide if they want to do that async or nor.
…-for-apple-platforms-sdk-setup
itaybre
deleted the
itay/cocoa-170-improve-onboarding-snippets-for-apple-platforms-sdk-setup
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
…ion options (#92506) Apple onboarding only had Swift + UIKit verification steps. Added: - Objective C code - Non UI options to verify the setup Fixes [getsentry/sentry-cocoa#4991](getsentry/sentry-cocoa#4991) ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple onboarding only had Swift + UIKit verification steps.
Added:
Fixes getsentry/sentry-cocoa#4991
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.