-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(releases): Bulk read and update on the happy path #92508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmanallen
wants to merge
19
commits into
master
Choose a base branch
from
cmanallen/release-bulk-query-health-task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+317
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/getsentry/sentry into cmanallen/releases-refactor-health-task
cmanallen
commented
May 29, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92508 +/- ##
==========================================
+ Coverage 87.78% 87.92% +0.14%
==========================================
Files 10258 10250 -8
Lines 588215 587705 -510
Branches 22859 22727 -132
==========================================
+ Hits 516347 516742 +395
+ Misses 71421 70541 -880
+ Partials 447 422 -25 |
aliu39
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
aliu39
reviewed
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently we are reading then updating each release individually. This is inefficient. We can read and update multiple releases at a time. As of the most recent run we read and updated 100x the number of rows in the happy path as we did the unhappy path. By implementing the bulk logic in the happy path first we can minimize our change surface and receive 99% of the reward. Note: tasks are chunked by organization so we can't move everything into a single query. But for the scope of an individual task (org) we are reading and updating with two queries.
Moving to this bulk refactor allowed us to further flatten the function definitions. Making them more tractable when trying to read and understand the code. This new behavior has unit and integration testing in addition to the unchanged functional test coverage. In a follow up PR I'll clean up the unhappy path.
Current total system time is ~15 minutes. We'll measure success by stable operation and improvements to total system time.