chore(devservices): Remove all old sentry devservices code #92512
+78
−991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
joshuarli
reviewed
May 29, 2025
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def get_docker_client() -> Generator[docker.DockerClient]: |
There was a problem hiding this comment.
there's a few imports you'll have to address too
[email protected] ~/d/sentry master $ rg -S 'devservices import' 0
bin/split-silo-database
8:from sentry.runner.commands.devservices import get_docker_client
src/sentry/testutils/pytest/relay.py
14:from sentry.runner.commands.devservices import get_docker_client
src/sentry/runner/commands/devserver.py
12:from sentry.runner.commands.devservices import get_docker_client
There was a problem hiding this comment.
yeah, I noticed thought this might be a bit easier to do
There was a problem hiding this comment.
going to punt this until next week or so for now
joshuarli
reviewed
May 29, 2025
| except docker.errors.DockerException: | ||
| if DARWIN: | ||
| if USE_COLIMA: | ||
| click.echo("Attempting to start colima...") |
There was a problem hiding this comment.
the expectation before was that devservices would automatically try and start colima if it couldn't connect to a docker daemon
now it's this (and you can't even use --help):
[email protected] ~/d/sentry master $ .venv/bin/devservices up 127
Unable to connect to the docker daemon. Is the docker daemon running?
[email protected] ~/d/sentry master $ .venv/bin/devservices --help 1
Unable to connect to the docker daemon. Is the docker daemon running?
before we remove all this (long awaited!) can we at least get devservices to do this on macos?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
devservices toggleis in, we should be safe to remove this codehttps://linear.app/getsentry/issue/DI-560/completely-remove-code-related-to-sentry-devservices