ref(workflow_engine): Change the issue fingerprint to be prefixed with detector
#92527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92527 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 10234 10234
Lines 586895 586896 +1
Branches 22799 22799
=======================================
+ Hits 515836 515846 +10
+ Misses 70629 70620 -9
Partials 430 430 |
evanpurkhiser
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@evanpurkhiser brought up a great point that it's not clear what's being stored and that the id could easily collide with other models. To address this, prefixing the fingerprint with
detectorwill help illustrate the difference and avoid collisions.