ref(insights): remove span.module filter if span.op is provided
#92578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92578 +/- ##
==========================================
+ Coverage 86.81% 87.89% +1.07%
==========================================
Files 10244 10237 -7
Lines 587471 586765 -706
Branches 22817 22789 -28
==========================================
+ Hits 510000 515717 +5717
+ Misses 77041 70622 -6419
+ Partials 430 426 -4 |
…ule-filters-when-spanop-filter-is-provided
gggritso
approved these changes
Jun 2, 2025
DominikB2014
deleted the
dominikbuszowiecki/dain-575-remove-spanmodule-filters-when-spanop-filter-is-provided
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
…92578) If there is an equivalent query that can be represented in a simpler manor, it should be used instead. When you open an insight chart in explore, we don't want users to be confused what the query is doing. In this case we remove the `span.module` filter, anytime there's an appropriate `span.op` filter as well. for example `span.category:http span.op:http.client` - used in the http module, can be simplified to `span.op:http.client` as the category filter is a superset of the operation filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an equivalent query that can be represented in a simpler manor, it should be used instead. When you open an insight chart in explore, we don't want users to be confused what the query is doing.
In this case we remove the
span.modulefilter, anytime there's an appropriatespan.opfilter as well.for example
span.category:http span.op:http.client- used in the http module, can be simplified tospan.op:http.clientas the category filter is a superset of the operation filter