Skip to content

Refactor: rename n_swa to n_aux #13019

Closed
Closed
@ngxson

Description

@ngxson

Background Description

Ref: #12791 (comment)

This won't be a simple renaming, but we also need to update some logic:

I'll do this after having the logits matching automated test. The problem is that changing name n_swa to n_pattern_aux make the code checking if (n_swa) then using SWA becomes invalid. It should now become if (n_pattern_aux && is_swa) then use SWA

I think it's better to add an enum called llama_mask_aux having 3 values: none, swa, chunked ; so that the code will become more clear

Possible Refactor Approaches

Add enum llama_mask_aux

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions