Skip to content

Fix rocWMMA build documentation #12243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Headcrabed
Copy link

Current HIP build manual about rocWMMA actually not working under linux, so here's the fix for this.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 7, 2025
@Headcrabed
Copy link
Author

@ggerganov ping

@ggerganov ggerganov requested a review from IMbackK March 9, 2025 17:07
@IMbackK
Copy link
Collaborator

IMbackK commented Mar 9, 2025

I don't think this has anything to do with windows vs Linux but rather with compiling with hipcc vs compiling with plain clang as cxx compiler. Regardless I think CMAKE_HIP_FLAGS should work in all cases, but this would have to test than on windows, which I don't have, but I will try doing so on ci soon

@Headcrabed
Copy link
Author

I don't think this has anything to do with windows vs Linux but rather with compiling with hipcc vs compiling with plain clang as cxx compiler. Regardless I think CMAKE_HIP_FLAGS should work in all cases, but this would have to test than on windows, which I don't have, but I will try doing so on ci soon

@IMbackK Currently DCMAKE_CXX_FLAGS won't work in linux, but I don't have a test environment to try DCMAKE_HIP_FLAGS in windows. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants