Implemented Spellcheck for Llama.cpp #7884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing from simple.cpp
mofosyne
added
the
Review Complexity : Low
HanClinto
reviewed
Jul 11, 2024
| # Llamacheck: Basic Spellcheck and Grammarcheck using Llama | ||
|
|
||
|
|
||
| The attached file provides a basic implementation of LLama to |
There was a problem hiding this comment.
Suggested change
| The attached file provides a basic implementation of LLama to | |
| The attached file provides a basic implementation of LLama to |
HanClinto
reviewed
Jul 11, 2024
| We use it as follows: | ||
| ```console | ||
| make llamacheck | ||
| ./llamacheck <./models/llamacheck.gguf> |
There was a problem hiding this comment.
End-of-line whitespace is making CI fail the editorconfig check.
Suggested change
| ./llamacheck <./models/llamacheck.gguf> | |
| ./llamacheck <./models/llamacheck.gguf> |
HanClinto
reviewed
Jul 11, 2024
| llama_backend_free(); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
Also needs a final newline at the end of the file.
Suggested change
| } | |
| } | |
ggerganov
added
the
demo
vignesh1507
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented basic spellcheck using llama. Fixed binary issues, etc from before.